chore: add a mechanism to set multiple envs per configuration #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdinur
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3679 +/- ##
==========================================
- Coverage 98.11% 98.10% -0.01%
==========================================
Files 1225 1225
Lines 72519 72543 +24
Branches 3446 3448 +2
==========================================
+ Hits 71149 71171 +22
- Misses 1370 1372 +2 ☔ View full report in Codecov by Sentry. |
mabdinur
commented
Jun 7, 2024
marcotc
approved these changes
Jun 7, 2024
…-multiple-configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
resolved_envinstance method for the Options class. This will allow developers to detect which environment variable were used to set a configuration.Motivation:
Additional Notes:
How to test the change?
Unsure? Have a question? Request a review!